-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue that when add user to cache #21
Comments
I'm experiencing this issue too, I suspect its when the final page has the maximum number of scores in pagination (i.e. 8 scores), so there's no new page to get. The responsible code is likely here: ScoreSaberEnhanced/src/api/scoresaber.ts Line 29 in 52c5a05
I think an additional check should be added when fetching a score page for a 404 status code, stopping pagination and assuming it's the end of the results. |
I created a PR to fix this: #23 |
fix: handle 404 in score pagination (fixes #21)
Adding some users to the cache sometimes fails, the number of empty pages cannot be read.
The text was updated successfully, but these errors were encountered: