Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue that when add user to cache #21

Closed
354316936 opened this issue Sep 15, 2020 · 2 comments
Closed

Issue that when add user to cache #21

354316936 opened this issue Sep 15, 2020 · 2 comments

Comments

@354316936
Copy link

image
image

Adding some users to the cache sometimes fails, the number of empty pages cannot be read.

@Lemmmy
Copy link
Contributor

Lemmmy commented May 8, 2021

I'm experiencing this issue too, I suspect its when the final page has the maximum number of scores in pagination (i.e. 8 scores), so there's no new page to get. The responsible code is likely here:

was_last_page: recent_songs.scores.length < 8

I think an additional check should be added when fetching a score page for a 404 status code, stopping pagination and assuming it's the end of the results.

@Lemmmy
Copy link
Contributor

Lemmmy commented May 8, 2021

I created a PR to fix this: #23

@Splamy Splamy closed this as completed in daf46e9 May 9, 2021
Splamy added a commit that referenced this issue May 9, 2021
fix: handle 404 in score pagination (fixes #21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants