Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added percentage values for songs without star rating #20

Merged
merged 2 commits into from Aug 13, 2020
Merged

Added percentage values for songs without star rating #20

merged 2 commits into from Aug 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2020

for leaderboard: add percentage if it is not present in a score row
for profile page: add percentage if not already set on ScoreSaber, percentage value replace weighted pp value (it is always = 0.00pp on this maps)

Karghoff and others added 2 commits August 8, 2020 20:33
for leaderboard: add percentage if it is not present in a score row
for profile page: add percentage if not already set on ScoreSaber, percentage value replace weighted pp value (it is always = 0.00pp on this maps)
@Splamy
Copy link
Owner

Splamy commented Aug 13, 2020

Thanks for this nice addition.
I've added a few changes before pulling, mostly changes to the code style to fit the reset, deduplicating some code, and flatten the if-trees since I find them more readable this way.

@Splamy Splamy merged commit b517cf9 into Splamy:master Aug 13, 2020
@ghost
Copy link
Author

ghost commented Aug 13, 2020

Glad to hear that
I did not work much with TS and was ready for remarks
I will study your changes later
Thank :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant