Ensuring that drag does not move slides more than options.flickMaxPages
allows
#1118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you drag the slider too fast, it moves more than
options.flickMaxPages
.For example, there is a problem with caused with this config.
video5411494184043422802.mp4
In this video you can see that sometimes slider moves more than 1 page. After some digging I found that this is
computeDestination
s problem. In fact, it'sgetPosition
that causes this error. If you drag fast, it calculates that you are already at the next slide, but in reality, you are not.So in this case I just added a new additional check that splide does not move more than it should.
Sorry for no related issue. This started as a local critical bug on our website so we can't wait too long. We have already switched to a forked version and have tested it in production mode. But I added more unit-tests to be sure.