Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PWA Collector and profiler views #162

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Apr 5, 2024

Implemented a new Progressive Web App (PWA) Collector to fetch and manage service worker and manifest details. Additionally, created multiple HTML templates for manifest, service worker, and other PWA tabs to properly display the collected data in UI.

Target branch: 1.2.x
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

Missing features (will be updated from time to time):

  • Manifest:
    • Other basic details
    • Shortcuts
    • Widgets(?)
    • File handlers
    • Protocol handlers
    • Related applications
  • Service worker:
    • Plugin details

2024-04-05_13h02_47

Implemented a new Progressive Web App (PWA) Collector to fetch and manage service worker and manifest details. Additionally, created multiple HTML templates for manifest, service worker, and other PWA tabs to properly display the collected data in UI.
@Spomky Spomky added this to the 1.2.0 milestone Apr 5, 2024
@Spomky Spomky self-assigned this Apr 5, 2024
Implemented a new Progressive Web App (PWA) Collector to fetch and manage service worker and manifest details. Additionally, created multiple HTML templates for manifest, service worker, and other PWA tabs to properly display the collected data in UI.
The PwaCollector class is updated to import Data from Symfony's VarDumper and modify the return type of the getData method. The isInstallable method is also refactored for a cleaner return statement. The exported_files workflow in the .github folder is altered to additionally exclude the 'templates' directory from the generated tar file.
The code change fixes filtering logic in the PwaCollector. Modified the array_filter function to use a callback that strictly checks for boolean values, ensuring more accurate status calculation.
@Spomky Spomky merged commit 27b1587 into 1.2.x Apr 7, 2024
7 checks passed
@Spomky Spomky deleted the features/profiler branch April 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant