SpongeForge for Minecraft 1.20.6 #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidane
reviewed
May 9, 2024
| @Inject(method = "tick", at = @At("HEAD")) | ||
| private void impl$onTick(final CallbackInfo ci) { | ||
| // In SpongeVanilla we do channel registration during this state, not sure if we need to do anything in SpongeForge | ||
| if (this.state == ServerLoginPacketListenerImpl.State.NEGOTIATING) { |
There was a problem hiding this comment.
See https://github.com/SpongePowered/Sponge/blob/api11/forge/src/mixins/java/org/spongepowered/common/mixin/core/server/network/ServerLoginPacketListenerImplMixin.java#L146
and https://github.com/SpongePowered/Sponge/blob/api11/forge/vanilla/src/mixins/java/org/spongepowered/vanilla/mixin/core/server/network/ServerLoginPacketListenerImplMixin_Vanilla.java#L80
After auth, we switch to state NEGOTIATING which is unused by vanilla MC. We use this state in SpongeVanilla to register channels and then we go to VERIFYING which will be handled by vanilla MC.
I had to replicate the NEGOTIATING -> VERIFYING switch in SpongeForge otherwise the login stay forever in state NEGOTIATING.
Zidane
reviewed
May 9, 2024
src/mixins/java/org/spongepowered/common/mixin/core/network/ConnectionMixin.java
Outdated
Show resolved
Hide resolved
Yeregorix
changed the title
Yeregorix
force-pushed
the
api11/forge
branch
2 times, most recently
from
46b82ea
to
3687b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.