Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendgrid v3 #16

Merged
merged 5 commits into from
Dec 19, 2019
Merged

Sendgrid v3 #16

merged 5 commits into from
Dec 19, 2019

Conversation

tomohara
Copy link
Contributor

This needs to me merged BEFORE of email changes to spoton2, else new email stuff will not work in hotspot.

…the adaptor for v3, i created a separate function for message construction, pulling it outside of the send function. this allowed for the message construction to be tested without triggering a send (unauthorized here api_key = 'unit_test').
@tomohara
Copy link
Contributor Author

Travis CI build fails ... I think I need to update setup.py etc to account for changes ...

@tomohara
Copy link
Contributor Author

setup.py now calls for sendgrid 6.1.0. the travis build seems to be ok now.

@jimbattin
Copy link
Member

@tomohara Can you bump the major version of this library to 2.0.0

@jimbattin jimbattin merged commit 91b8bf5 into master Dec 19, 2019
@jimbattin jimbattin deleted the sendgrid-v3 branch December 19, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants