Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the stale bot #1061

Merged
merged 1 commit into from
Feb 27, 2022
Merged

remove the stale bot #1061

merged 1 commit into from
Feb 27, 2022

Conversation

ayushnix
Copy link
Contributor

@ayushnix ayushnix commented Feb 24, 2022

The stale bot is considered harmful and for pretty good reasons in my opinion. It masks and hides legitimate issues just because they may not receive attention for a few months. Closing issues because they're old doesn't make them go away, it just hides them.

The [stale bot](https://github.com/marketplace/stale) is considered
[harmful](https://drewdevault.com/2021/10/26/stalebot.html) and for
pretty good reasons in my opinion. It masks and hides legitimate issues
just because they may not receive attention for a few months. Closing
issues because they're old doesn't make them go away, it just hides
them.
@JojiiOfficial
Copy link
Member

Closing issues because they're old doesn't make them go away, it just hides them

I don't agree. When maintaining a big project, you'll encounter a lot of "Issues" which ain't actually issues of the project itself but rather issues with the OS or the user doing something wrong. There were a lot of issues which seemed not to be actual issues and nobody cared anyways so we added stale. In general its a good idea but I think stale should ignore issues which have been reopened once and it definitely should reopen an issue again when a new comment has been made after closing it.

In general I agree with removing stale since it has mostly only caused trouble and since I think as maintainer user opinions should be strongly considered as well.

@ayushnix
Copy link
Contributor Author

ayushnix commented Feb 24, 2022

When maintaining a big project, you'll encounter a lot of "Issues" which ain't actually issues of the project itself but rather issues with the OS or the user doing something wrong.

I can empathize with this situation but if it ends up masking legit issues along with illegitimate issues, can we really call the bot beneficial?

Of course, this is just my humble opinion.

but I think stale should ignore issues which have been reopened once and it definitely should reopen an issue again when a new comment has been made after closing it.

If the stale bot can be configured to do that, I'm willing to push some changes to this PR.

@robinvd
Copy link
Contributor

robinvd commented Feb 25, 2022

I think we’ve had a significant amount of issues going stale while the reporter still has the issue. The current timeout for going stale is quite short considering the repo is not super active.

but it did solve an issue of an ever increasing backlog of issues

Overal im definitely in favor of changing the current setup, either remove it or change the settings

@JojiiOfficial JojiiOfficial merged commit 85a3696 into Spotifyd:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants