-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option for audio format #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works for me:
$ target/debug/spotifyd --no-daemon --audio-format "S32"
Loading config from "/home/user/.config/spotifyd/spotifyd.conf"
No password specified. Checking password_cmd
No password_cmd specified
No proxy specified
Using software volume controller.
Connecting to AP "ap.spotify.com:443"
Authenticated as "user" !
Using Alsa sink with format: S32
Country: "DE"
...
Now we'll just have to wait for maintainers to come around and review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two additional nitpicks. Looking over config.rs
I have some additional improvements in mind like switching to clap
or resurrecting this PR, but those are more general and definitely out-of-scope for this PR.
9c510cc
to
cf52e80
Compare
In the Also not much used to github PR, how the hell is there no comment thread ? Or am I missing something ? |
@sapristi With the recent PRs that have been merged, this PR now has merge conflicts. If you could resolve them, maybe we can get that into the next release? |
fc84cfd
to
62bee6d
Compare
I took the liberty to take this PR and rebase it on the current master. So this could potentially also go into the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
Add support for audio-format configuration.
Closes #1081