Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update badges and add link to matrix #1172

Merged
merged 2 commits into from
Mar 10, 2023
Merged

update badges and add link to matrix #1172

merged 2 commits into from
Mar 10, 2023

Conversation

eladyn
Copy link
Member

@eladyn eladyn commented Mar 2, 2023

This removes/updates some obsolete badges and adds a new one for the matrix room. (Preview)

Justification for the individual updates / removals:

  • contributors are also listed on the right side of the repo's front page and haven't been updated in a while
  • cargo downloads don't accurately represent the actual downloads of this project, which probably happen more via GitHub releases or other distributions (the shown number is less than the amount of stars this repo has)
  • the CI and CD badge didn't match the style of the others, so I went for the ones from shields.io

Now, when we're already at it, would you prefer a different style for the badges?

This removes/updates some obsolete badges and adds a new one for the matrix room.
@eladyn eladyn requested a review from a team March 2, 2023 17:26
Copy link
Member

@slondr slondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

With regards to styles: I think they all look fine, though if we do want to change it, flat-square looks the nicest to me.

@slondr slondr requested a review from a team March 9, 2023 00:40
@slondr slondr mentioned this pull request Mar 9, 2023
@slondr slondr added this to the v0.3.5 milestone Mar 9, 2023
@eladyn eladyn merged commit c6fb5b3 into master Mar 10, 2023
@eladyn eladyn deleted the badge-updates branch March 10, 2023 23:10
@eladyn
Copy link
Member Author

eladyn commented Mar 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants