Skip to content

SEC-2119: Add a 'form-parameter' attribute to <remember-me> #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

obecker
Copy link
Contributor

@obecker obecker commented Jan 13, 2013

This change extends the namespace configuration of
with a 'form-parameter' attribute. The introduced attribute sets
the 'parameter' property of AbstractRememberMeServices.

This enables overriding the default value of
'_spring_security_remember_me' using the namespace configuration.

Additional changes:

  • Map the default schema location spring-security.xsd to the
    3.2 version (spring-security-3.2.xsd)

Issue: SEC-2119

I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.

This change extends the namespace configuration of <remember-me>
with a 'form-parameter' attribute. The introduced attribute sets
the 'parameter' property of  AbstractRememberMeServices.

This enables overriding the default value of
'_spring_security_remember_me' using the namespace configuration.

Additional changes:
* Map the default schema location spring-security.xsd to the
  3.2 version (spring-security-3.2.xsd)

Issue: SEC-2119
@rwinch
Copy link
Member

rwinch commented Mar 1, 2013

Thank you for the pull request! I have added this to master with a few modifications.

  • Updated so the build would pass (some files still referenced 3.1 instead of 3.2)
  • Changed the form-parameter to rememberme-parameter to make more explicit
  • Updated the commit comment to match Spring Security's contributing guidelines (i.e. prefix commit comment with the JIRA ID)
  • use the rnc file instead of directly editing the xsd file

Thanks again for the contribution!

@rwinch rwinch closed this Mar 1, 2013
@obecker
Copy link
Contributor Author

obecker commented Mar 4, 2013

Alright, then the XML configuration would look like

<remember-me rememberme-parameter="foobar" ... />

I'm OK with making the attribute name more explicit, however, I believe a additional hyphen would make it even more consistent, thus I would suggest remember-me-parameter instead of rememberme-parameter.

@rwinch
Copy link
Member

rwinch commented Mar 4, 2013

Good feedback...I had debated this myself. If you have a chance, please send a pull request for these changes.

NOTE: Please be sure to run the build to ensure all tests pass before submitting (i.e. the doc will need updated)

@obecker
Copy link
Contributor Author

obecker commented Mar 5, 2013

Done.
See #31

ashimagarg67 pushed a commit to ashimagarg67/spring-security that referenced this pull request Apr 23, 2024
 This change extends pull request spring-projects/spring-security#26
 and its subsequent changes by renaming the attribute name 'rememberme-parameter' to
 'remember-me-parameter'.

 The spelling including the additional hyphen in 'remember-me-parameter' is more consistent
 with the default spelling of the 'remember-me' functionality.

 Issue: SEC-2119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants