Added Java config support to Message Servlet #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Java configuration support to MessageDispatcherServlet so that it can be configured within a ServletContextListener or a ServletContainerInitializer. Issue: SWS-832
poutsma
pushed a commit
that referenced
this pull request
Jul 2, 2013
* SWS-832: Added Java config support to Message Servlet
|
Merged. Thanks for the high quality of the pull request. I didn't have to change anything before merging :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Java configuration support to
MessageDispatcherServletso that it can be configured within aServletContextListeneror aServletContainerInitializer.The change was extremely minor. Biggest change is the Javadoc. I added a new constructor to call
FrameworkServlet#FrameworkServlet(WebApplicationContext)and then copied the JavaDoc fromFrameworkServletto the new constructor (exactly like it was done inDispatcherServlet). Works great!What's the roadmap for 2.1.4? I'd love to see this committed and 2.1.4 rolled out soon.
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.
Issue: SWS-832