Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File URI fix + small changes to logviewer #34

Merged
merged 7 commits into from
Jul 28, 2017
Merged

File URI fix + small changes to logviewer #34

merged 7 commits into from
Jul 28, 2017

Conversation

taurgis
Copy link
Contributor

@taurgis taurgis commented Jul 28, 2017

No description provided.

@taurgis
Copy link
Contributor Author

taurgis commented Jul 28, 2017 •
edited
Loading

Changes:

  • Fix to the cartridges view (Uri.file instead of manual file://) - Uri.file contains code for windows paths
  • Removed cartridge context types in the logview
  • Filtered out folders in the log view like sitemap & dbinit, since they are not log files they can not be opened - opening dbinit shows the HTML of the folder page

@taurgis taurgis mentioned this pull request Jul 28, 2017
Closed
@taurgis taurgis changed the title File URI the right way File URI fix + small changes to logviewer Jul 28, 2017
@SqrTT SqrTT merged commit 9d35e16 into SqrTT:develop Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taurgis @SqrTT