Change to statSync so symlink dirs can be uploaded #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGD1953
approved these changes
Oct 18, 2017
|
Hi @aburgett87 Does this works for Windows users too? (I don't have Windows machine near me) |
|
Hi @SqrTT, Yes, this was tested on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects that don't conform to the standard of placing all cartridges in the path need to have the ability to upload all of the cartridges.
A solution proposed is to use symlinks so that the project appears to conform to the standard.
The only issue with the solution is that this extension doesn't pick up the symlink directories. Changing lstatSync to statSync will fix the issue