Correct schema name quoting #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, certain `ALTER... SCHEMA` statements will fail if they address a schema whose name contains a hyphen, which can happen, for instance, managing the personal schema of a user whose name contains a hyphen. This commit wraps the schema name in quotes for the two affected sql queries, and bumps pgbedrock to 0.3.2. Closes #43.
2.7.3 breaks against current versions of glibc
There exists a test for a role with a dash in it having a personal schema. However, the test case is too simple, and does not force pgbedrock to configure default permissions. This test case *does* force default permission configuration, so we can see that roles with dashes and personal schemas is, in fact, broken.
|
This isn't going to fix the problem, which is very deep, and gets us in to complex questions of YAML and deep restructurings. This seems unrelated to #7; in fact it is entirely about that, way down in the guts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, certain
ALTER... SCHEMAstatements will fail if they address aschema whose name contains a hyphen, which can happen, for instance, managing
the personal schema of a user whose name contains a hyphen. This commit wraps
the schema name in quotes for the two affected sql queries, and bumps pgbedrock
to 0.3.2.
Closes #43.