Move pinned dependencies to requirements.txt #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned dependencies in
setup.py
make it difficult to usepgbedrock
in environments that are shared with other packages. If a user upgrades a dependency and tries to executepgbedrock
they can get apkg_resources.DistributionNotFound
error.This pull request relaxes the dependency constraints in
setup.py
and addsrequirements.txt
. The relaxed constraints insetup.py
enable the user to executepgbedrock
in more environments, while the pinning inrequirements.txt
provides users and developers with a "known good" environment.pgbedrock
seems to work correctly with the latest versions of all dependencies. I do not know whether there are any known minimum version requirements for any of the dependencies, but if there are please add them tosetup.py
.