Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test alias types byte and rune #10

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Conversation

heppu
Copy link
Contributor

@heppu heppu commented Sep 26, 2016

Added test cases for byte and rune to close issue #9.

@heppu heppu changed the title Test alis types byte and rune Test alias types byte and rune Sep 26, 2016
@StabbyCutyou
Copy link
Owner

Although package generics maintains the highest level of standards around tests passing, the Travis integration is still a WIP, therefore I do not consider it a blocking issue at this time.

That said, I must still verify these changes by hand before accepting the PR.

@heppu
Copy link
Contributor Author

heppu commented Sep 26, 2016

I have to say that I really appreciate you taking time to verifying these changes by hand while CI is still in WIP considering amount of code these changes may have on impact in g.go.

@StabbyCutyou
Copy link
Owner

It's hard work, but that's what passion is all about. I'll make the hard
personal sacrifices to ensure the success of something I truly believe is
the future of golang.

On Sep 26, 2016 6:23 AM, "Henri Koski" notifications@github.com wrote:

I have to say that I really appreciate you taking time to verifying these
changes by hand while CI is still in WIP considering amount of code these
changes may have on impact in g.go.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdTKuzXHXzusDtgfJvVZSXTOoxSFqmUks5qt50lgaJpZM4KGWKR
.

@StabbyCutyou StabbyCutyou merged commit ea4209b into StabbyCutyou:master Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants