Add CAI Parameters to Image Parameters #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardKennedy1
commented
Jun 5, 2023
Stability should sign image artifacts using the C2PA tool if CAI Parameters are set in the request. This commit creates a new CAI Parameters message, which contains the model name and version. This message can be optionally included in Image Parameters to get C2PA signing of the returned image artifacts.
RichardKennedy1
force-pushed
the
richard/add_support_for_cai
branch
from
b950dcd
to
1deb933
Compare
Model name and version can be extracted from the engine id. Consequently, we should not make it a parameter in the request. Instead CAI Parameters allows users to specify the type of parameters which can be passed in. Currently the only option is an enum representing the type of model metadata which will be attatched to the image.
RichardKennedy1
commented
Jun 5, 2023
This commit also introduces an unspecified enum value as the default. This will make the code safer in the future while also adhering to common API guidelines.
brianfitzgerald
approved these changes
Jun 12, 2023
jbdoto
reviewed
Jun 12, 2023
Following suggestion from buf lint
|
Kudos, SonarCloud Quality Gate passed!
|
johnsabath
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stability should sign image artifacts using the C2PA tool if CAI Parameters are set in the request. This commit creates a new CAI Parameters message, which allows users to specify the type of information to attach as providence data. Currently the only option is to attach the engine id. This message can be optionally included in Image Parameters to get C2PA signing of the returned image artifacts.