test(test-helpers): fix changes to setupPasteSupport causing test fai…

…lures
StackExchange · Jul 21, 2022 · aa50811 · aa50811
1 parent 0bf0bdf
commit aa50811
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/test/rich-text/test-helpers.ts b/test/rich-text/test-helpers.ts
@@ -106,7 +106,7 @@ export function runCommand(
 }
 
 /** Sets up ProseMirror paste support globally for jsdom */
-export function setupPasteSupport(dropElement?: Element): void {
+export function setupPasteSupport(): void {
     Range.prototype.getClientRects = () => ({
         item: () => null,
         length: 0,
@@ -115,14 +115,21 @@ export function setupPasteSupport(dropElement?: Element): void {
 
     Range.prototype.getBoundingClientRect = () =>
         jest.mocked<DOMRect>({} as never);
-
-    Document.prototype.elementFromPoint = () => dropElement;
 }
 
 /** Tears down ProseMirror paste support globally for jsdom */
 export function cleanupPasteSupport(): void {
     Range.prototype.getClientRects = undefined;
     Range.prototype.getBoundingClientRect = undefined;
+}
+
+/** Sets up ProseMirror drop support globally for jsdom */
+export function setupDropSupport(dropElement: HTMLElement) {
+    Document.prototype.elementFromPoint = () => dropElement;
+}
+
+/** Tears down ProseMirror drop support globally for jsdom */
+export function cleanupDropSupport() {
     Document.prototype.elementFromPoint = () => undefined;
 }
 

diff --git a/test/shared/prosemirror-plugins/image-upload.test.ts b/test/shared/prosemirror-plugins/image-upload.test.ts
@@ -1,4 +1,4 @@
-import { EditorState, PluginView } from "prosemirror-state";
+import { EditorState } from "prosemirror-state";
 import { EditorView } from "prosemirror-view";
 import { RichTextEditor } from "../../../src/rich-text/editor";
 import {
@@ -18,9 +18,11 @@ import {
 import { commonmarkSchema } from "../../../src/commonmark/schema";
 import { stackOverflowValidateLink } from "../../../src/shared/utils";
 import {
+    cleanupDropSupport,
     cleanupPasteSupport,
     dispatchDropEvent,
     dispatchPasteEvent,
+    setupDropSupport,
     setupPasteSupport,
     testRichTextSchema,
 } from "../../rich-text/test-helpers";
@@ -149,7 +151,7 @@ describe("image upload plugin", () => {
         });
 
         it("should handleDrop on editor", () => {
-            setupPasteSupport(view.editorView.dom);
+            setupDropSupport(view.editorView.dom);
 
             let state = getPluginStateByName<{ file: File }>(
                 view.editorView.state,
@@ -170,7 +172,7 @@ describe("image upload plugin", () => {
 
             expect(state.file).toBeTruthy();
 
-            cleanupPasteSupport();
+            cleanupDropSupport();
         });
 
         it("should handlePaste on editor", () => {