Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Go version) Add release workflow #318

Merged
merged 5 commits into from
Nov 19, 2020
Merged

(Go version) Add release workflow #318

merged 5 commits into from
Nov 19, 2020

Conversation

MaxHorstmann
Copy link
Contributor

@MaxHorstmann MaxHorstmann commented Nov 17, 2020

Add a workflow to automatically build the Go version and attach all three binaries to a published release.

image

Heavily inspired by dnscontrol.

@MaxHorstmann MaxHorstmann marked this pull request as ready for review November 17, 2020 13:38
tlimoncelli
tlimoncelli previously approved these changes Nov 17, 2020
@MaxHorstmann MaxHorstmann marked this pull request as draft November 17, 2020 13:43
@MaxHorstmann MaxHorstmann changed the title Add release workflow (Go version) Add release workflow Nov 17, 2020
@MaxHorstmann
Copy link
Contributor Author

MaxHorstmann commented Nov 18, 2020

@tlimoncelli would you re-review please? This appears to work as expected. Note that in order for the Go code to build, there has to be a v2 tag because of the semantic versioning.

@MaxHorstmann MaxHorstmann merged commit d45564d into master Nov 19, 2020
@MaxHorstmann MaxHorstmann deleted the release-workflow branch November 19, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants