-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRANSIP: Audit records verified #2794
TRANSIP: Audit records verified #2794
Conversation
a.Add("ALIAS", rejectif.LabelNotApex) // Last verified 2024-01-11 | ||
|
||
a.Add("MX", rejectif.MxNull) // Last verified 2023-12-04 | ||
|
||
a.Add("TXT", rejectif.TxtHasBackticks) // Last verified 2023-12-04 | ||
a.Add("TXT", rejectif.TxtHasBackticks) // Last verified 2024-01-11 | ||
|
||
a.Add("TXT", rejectif.TxtHasDoubleQuotes) // Last verified 2023-12-04 | ||
a.Add("TXT", rejectif.TxtHasBackslash) // Last verified 2024-01-11 | ||
|
||
a.Add("TXT", rejectif.TxtHasBackslash) // Last verified 2023-12-04 | ||
a.Add("TXT", rejectif.TxtStartsOrEndsWithSpaces) // Last verified 2024-01-11 | ||
|
||
a.Add("TXT", rejectif.TxtStartsOrEndsWithSpaces) // Last verified 2023-12-10 | ||
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2024-01-11 | ||
|
||
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2023-12-10 | ||
a.Add("TXT", rejectif.TxtLongerThan(1024)) // Last verified 2024-01-11 | ||
|
||
a.Add("TXT", rejectif.TxtLongerThan(1024)) // Last verified 2023-12-15 | ||
a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2024-01-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep in sorted order:
a.Add("ALIAS", rejectif.LabelNotApex) // Last verified 2024-01-11
a.Add("MX", rejectif.MxNull) // Last verified 2023-12-04
a.Add("TXT", rejectif.TxtHasBackslash) // Last verified 2024-01-11
a.Add("TXT", rejectif.TxtHasBackticks) // Last verified 2024-01-11
a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2024-01-11
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2024-01-11
a.Add("TXT", rejectif.TxtLongerThan(1024)) // Last verified 2024-01-11
a.Add("TXT", rejectif.TxtStartsOrEndsWithSpaces) // Last verified 2024-01-11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not adjusted any ordering. That's the git diff being misleading. Please check commit by commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duh. I'm illiterate.
FYI: Another way verify these is to comment them out one at a time and run the integration tests to see if it still fails. For example, comment out This means n integration test runs for n lines in the file, but it is easier (to me) than creating a dnsconfig.js file. |
This was a continuation of several test cases from #2789. The problem observed from the TransIP API/Go package cannot be reproduced from the TransIP interface. 🙈 |
Verified the audit records against the TransIP API.
For completeness/archive purpose my testing steps/output
I ran a local DNSControl build with a modified
providers/transip/auditrecords.go
.LabelNotApex
TxtHasBackticks
TxtHasBackslash
TxtHasTrailingSpace
TxtStartsOrEndsWithSpaces
TxtIsEmpty
cc: Maintainer TransIP: @blackshadev