-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW FEATURE: Gather data for providers concurrently #2873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected by Check Git Status Action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes detected by Check Git Status Action
tlimoncelli
changed the title
Gather data for providers concurently
Gather data for providers concurrently
Mar 23, 2024
tlimoncelli
changed the title
Gather data for providers concurrently
NEW FEATURE: Gather data for providers concurrently
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: collect "preview" information in parallel to improve dnscontrol peformance.
dnscontrol ppreview
-- Like preview, but collects data in parallel for providers that permit it.dnscontrol ppush
-- Like ppreview but pushes--cmode=none
Don't do any work concurrently (useful when you find a bug)--cmode=all
Run all providers concurrently (dangerous!)NOTE: Eventually
ppreview
andppush
will replacepreview
andpush
. These are temporary commands. We'll probably do 1-2 public releases with thepp
versions before we remove the non-parallel verions.How to test this
Here's how to try the changes:
Is your provider safe to run concurrently?
Look for this line in the source file:
If you see
providers.Can()
then your provider has already been tested and verified to be working.If you'd like to test your provider, change
Cannot()
toCan()
and compile with the-race
flag. This will attempt to detect any race conditions.Please report any bugs, suggestions, or performance results in the comments below.