Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: CAA_BUILDER() with TTL() support #2978

Merged
merged 1 commit into from
May 29, 2024

Conversation

cafferata
Copy link
Collaborator

@cafferata cafferata commented May 24, 2024

The domain modifier CAA_BUILDER() with record modifier TTL() support.

dnsconfig.js before/after

DEFAULTS(
    DefaultTTL('1d')
)
D('jcid.nl',
    PROVIDER_NONE,
    DnsProvider(PROVIDER_TRANSIP),
    CAA_BUILDER({
        label: '@',
        iodef: 'mailto:info@jcid.nl',
        iodef_critical: true,
        issue: [
            'letsencrypt.org',
            'sectigo.com',
        ],
        issue_critical: true,
        issuewild: 'none',
        issuewild_critical: true,
+       ttl: TTL('1h'),
    }),
dnscontrol preview --domains jcid.nl --dev
******************** Domain: jcid.nl
8 corrections (transip)
#1: [1/2] delete: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#2: [1/2] delete: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#3: [1/2] delete: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#4: [1/2] delete: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#5: [2/2] create: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#6: [2/2] create: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#7: [2/2] create: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
#8: [2/2] create: ± MODIFY-TTL jcid.nl CAA 128 iodef "mailto:info@jcid.nl" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "letsencrypt.org" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issue "sectigo.com" ttl=(86400->300)
± MODIFY-TTL jcid.nl CAA 128 issuewild ";" ttl=(86400->300)
Done. 8 corrections.

Fixes #2977.

@cafferata cafferata self-assigned this May 24, 2024
@cafferata cafferata marked this pull request as draft May 28, 2024 20:13
@cafferata cafferata marked this pull request as ready for review May 29, 2024 19:18
@cafferata
Copy link
Collaborator Author

cafferata commented May 29, 2024

Just did a rebase on main.

@tlimoncelli
Copy link
Contributor

Thanks!

@tlimoncelli tlimoncelli merged commit 1f4c4c6 into StackExchange:main May 29, 2024
6 checks passed
@cafferata cafferata deleted the feature/caa_builder_ttl branch May 30, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to set CAA_BUILDER TTL?
2 participants