Add support for huaweicloud dns #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huihuimoe <github@huihui.contact>
Signed-off-by: huihuimoe <github@huihui.contact>
tlimoncelli
reviewed
Jun 13, 2024
tlimoncelli
reviewed
Jun 13, 2024
|
Hello! Thank you for the contribution! It looks excellent! I made a few minor suggestions. Once the documentation is finalized it should be ready for merge. Thanks again! |
|
Hi, |
cafferata
reviewed
Jun 15, 2024
cafferata
suggested changes
Jun 15, 2024
huihuimoe
force-pushed
the
provider-huaweicloud
branch
from
6c22f41
to
703bebe
Compare
tlimoncelli
reviewed
Jun 17, 2024
Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
…ectly from the zone
|
Works perfectly on integrationTest and on my own domain now. |
tlimoncelli
approved these changes
Jun 17, 2024
|
Looks good! I'll merge soon. If you would like HUAWEICLOUD to be automatically tested as part of each release, please follow the instructions here: https://docs.dnscontrol.org/developer-info/byo-secrets Thanks for contributing this! I'm sure a lot of people will find it useful! |
cafferata
added a commit
to cafferata/dnscontrol
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, I'm trying out dnscontrol with huaweicloud dns, but dnscontrol doesn't support it, so I wrote it.
This is the homepage of huaweicloud dns, please check it out
https://www.huaweicloud.com/intl/en-us/product/dns.html
I ran the built-in integrationTest test and it should all pass.
https://paste.ubuntu.com/p/2Wv8rcJJs4/
There is still some work left to do, I will add it later.
If you have any questions, please feel free to ask, thanks!