Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment step race condition #65

Closed
LindsayHill opened this issue Jan 25, 2019 · 1 comment
Closed

Deployment step race condition #65

LindsayHill opened this issue Jan 25, 2019 · 1 comment

Comments

@LindsayHill
Copy link
Contributor

In https://github.com/StackStorm-Exchange/ci/blob/master/.circle/deployment#L23, the deployment script clones the github.com/StackStorm-Exchange/index repo, then updates index.json and the pack icon.png.

It then commits & pushes those changes.

If multiple packs are attempting to deploy changes around the same time, this can result in a race where multiple packs are attempting to push to master at the same time.

Code needs to be updated to handle this, and attempt to rebase with latest changes, and push again. Possibly with a few retries.

@cognifloyd
Copy link
Member

This is obsolete now that index regeneration happens in the index repo itself.

@cognifloyd cognifloyd closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants