Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer OpenAI pack from Incubator #1

Merged
merged 11 commits into from
Sep 15, 2023
Merged

Transfer OpenAI pack from Incubator #1

merged 11 commits into from
Sep 15, 2023

Conversation

stackstorm-neptr
Copy link
Contributor

Pack: OpenAI Query Pack
Description: Pack to query OpenAI API
Incubator PR: StackStorm-Exchange/exchange-incubator#179

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2023

CLA assistant check
All committers have signed the CLA.

@arm4b
Copy link
Member

arm4b commented Sep 5, 2023

@dalarsen The new repo was bootstrapped based on your PR in the StackStorm-Exchange incubator StackStorm-Exchange/exchange-incubator#179. We're getting closer!

Looking at the GH workflow of the bootstrapped pack

jobs:
# This is mirrored in the release workflow.
build_and_test:
name: 'Build and Test'
uses: StackStorm-Exchange/ci/.github/workflows/pack-build_and_test.yaml@master
with:
enable-common-libs: false
#apt-cache-version: v0
#py-cache-version: v0

it's referring to a common workflow in the stackstorm-exchange/ci/ repo: https://github.com/StackStorm-Exchange/ci/blob/master/.github/workflows/pack-build_and_test.yaml

I think it makes sense to make the python version configurable via inputs
https://github.com/StackStorm-Exchange/ci/blob/master/.github/workflows/pack-build_and_test.yaml#L43-L44
and so then in this openai pack CI we could just specify the expected python version, similar to other inputs like py-cache-version: v0.

If you could open a PR against the https://github.com/StackStorm-Exchange/ci/blob/master/.github/workflows/pack-build_and_test.yaml to make the python version configurable via inputs, - that will help, I'll merge it.

@arm4b arm4b changed the title Transfer OpenAI Query Pack pack from Incubator Transfer OpenAI pack from Incubator Sep 5, 2023
@arm4b arm4b merged commit 2642578 into main Sep 15, 2023
1 check failed
@arm4b arm4b deleted the transfer branch September 15, 2023 19:12
arm4b added a commit that referenced this pull request Sep 15, 2023
arm4b added a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants