Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cert-based SSH Auth Issues in Paramiko #6017

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jk464
Copy link
Contributor

@jk464 jk464 commented Aug 23, 2023

Paramiko 2.10.1 is effect by:

paramiko/paramiko#2017

That break cert-based SSH auth when using Paramiko, both are fixed in 2.10.5

This PR bumps Paramiko to 2.10.5 to fix this issue

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Aug 23, 2023
@jk464 jk464 force-pushed the bugfix/paramiko-sshcert-pr branch from 701b072 to 2ed68a1 Compare August 23, 2023 11:50
@nzlosh
Copy link
Contributor

nzlosh commented Aug 23, 2023

Thanks for creating this PR. Perhaps remove paramiko/paramiko#1963 from the documentation as it only concerns paramiko 2.9 branch where st2 is already pinned the 2.10 branch.

@jk464 jk464 force-pushed the bugfix/paramiko-sshcert-pr branch from 2ed68a1 to fc63d16 Compare August 23, 2023 12:49
@jk464
Copy link
Contributor Author

jk464 commented Aug 23, 2023

@nzlosh Removed the reference to paramiko/paramiko#1963

@jk464 jk464 force-pushed the bugfix/paramiko-sshcert-pr branch from fc63d16 to 6dcfcd8 Compare August 24, 2023 11:23
@jk464
Copy link
Contributor Author

jk464 commented Aug 24, 2023

Noticed I made a mistake in the changelog and duplicated the Fixed section - I've tidied that up now

@nzlosh nzlosh merged commit b2dad1e into StackStorm:master Sep 14, 2023
38 of 39 checks passed
@nzlosh nzlosh added this to the 3.9.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants