Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pants managed venv in Makefile #6130

Draft
wants to merge 92 commits into
base: master
Choose a base branch
from
Draft

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    2169fdc View commit details
    Browse the repository at this point in the history
  2. install pants

    cognifloyd committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    88fafe5 View commit details
    Browse the repository at this point in the history
  3. submodules

    cognifloyd committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    ff3f266 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    752d51f View commit details
    Browse the repository at this point in the history
  5. debug unit tests

    cognifloyd committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    89fafdc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3575452 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ff7f9b3 View commit details
    Browse the repository at this point in the history
  8. gha

    cognifloyd committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    383e91f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e863365 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bf2b628 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    173dde2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    76c9d10 View commit details
    Browse the repository at this point in the history
  2. fight with screen

    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0fa4db8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd571db View commit details
    Browse the repository at this point in the history
  4. more debug!

    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    16ac510 View commit details
    Browse the repository at this point in the history
  5. more debug

    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    748514a View commit details
    Browse the repository at this point in the history
  6. more debug

    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    54417e1 View commit details
    Browse the repository at this point in the history
  7. more debug

    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c33ed15 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c28a08a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7431fd5 View commit details
    Browse the repository at this point in the history
  10. regen lockfile constraining kombu

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      amqp                           5.0.6        -->   5.2.0
      netaddr                        1.1.0        -->   1.2.1
      prettytable                    3.9.0        -->   3.10.0
      pytest                         8.0.0        -->   8.0.1
      urllib3                        2.2.0        -->   2.2.1
      vine                           5.0.0        -->   5.1.0
    
    ==                !! Downgraded dependencies !!                 ==
    
      kombu                          5.2.2        -->   5.0.2
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    36252cc View commit details
    Browse the repository at this point in the history
  11. reenable the amqp constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                !! Downgraded dependencies !!                 ==
    
      amqp                           5.2.0        -->   5.0.6
      vine                           5.1.0        -->   5.0.0
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fecd628 View commit details
    Browse the repository at this point in the history
  12. unpin eventlet now that new versions work with gunicorn

    and also adjust a couple of other constraints.
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4fbbf52 View commit details
    Browse the repository at this point in the history
  13. pants: unpin eventlet

    Oops. missed this when we bumped the version for the rest of st2.
    
    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      bcrypt                         3.2.0        -->   3.2.2
      eventlet                       0.30.3       -->   0.35.1
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    535e91c View commit details
    Browse the repository at this point in the history
  14. pants: require pyOpenSSL

    why? I do not know.
    
    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                      Added dependencies                      ==
    
      pyopenssl                      24.0.0
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5b15bf8 View commit details
    Browse the repository at this point in the history
  15. constrain greenlet<3

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                !! Downgraded dependencies !!                 ==
    
      greenlet                       3.0.3        -->   2.0.2
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f0a9f74 View commit details
    Browse the repository at this point in the history
  16. constrain greenlet<2

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                !! Downgraded dependencies !!                 ==
    
      greenlet                       2.0.2        -->   1.1.3.post0
    cognifloyd committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    852b577 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    2ae2074 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. update pants st2.lock file as Github Action runs failed due to an out…

    …dated hash for st2-auth-ldap
    winem committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    635f238 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Merge pull request #6164 from winem/winem/pants-st2-lock-st2-auth-ldap

    update pants st2.lock file
    winem authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    2853c45 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Merge branch 'pants-upgrade' into pants-export-venv

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      bcrypt                         3.2.0        -->   3.2.2
      eventlet                       0.30.3       -->   0.36.1
    
    ==                !! Downgraded dependencies !!                 ==
    
      greenlet                       3.0.3        -->   1.1.3.post0
      kombu                          5.2.2        -->   5.0.2
    
    ==                      Added dependencies                      ==
    
      pyopenssl                      24.1.0
    cognifloyd committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    98033e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. better cache hash

    account for changes in the lockfiles
    
    This should effectively bust any cache, so we can eliminate the cache as
    the source of GHA issues.
    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    063ee69 View commit details
    Browse the repository at this point in the history
  2. pants fmt ::

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5eab3c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3767a56 View commit details
    Browse the repository at this point in the history
  4. remove reference to non-existent Popen.id attribute

    As far as I can tell, Popen has never had an 'id' attribute. It has 'pid'.
    I checked both cpython and eventlet sources.
    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7bcf5f9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    67c2bd2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7819e48 View commit details
    Browse the repository at this point in the history
  7. Makefile syntax

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c306172 View commit details
    Browse the repository at this point in the history
  8. Bash syntax

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    610d111 View commit details
    Browse the repository at this point in the history
  9. Bash syntax

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5fc7fb0 View commit details
    Browse the repository at this point in the history
  10. disable duplicate tests

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cd1b8af View commit details
    Browse the repository at this point in the history
  11. more debug

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d98d02b View commit details
    Browse the repository at this point in the history
  12. more debug

    cognifloyd committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1bd7a8d View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    3e4f763 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff330a7 View commit details
    Browse the repository at this point in the history
  3. drop some debug output

    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6388660 View commit details
    Browse the repository at this point in the history
  4. more debug logs

    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1b6142e View commit details
    Browse the repository at this point in the history
  5. Revert "more debug"

    This reverts commit c33ed15
    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c62c8b3 View commit details
    Browse the repository at this point in the history
  6. Revert "more debug"

    This reverts commit 54417e1
    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    13e01cf View commit details
    Browse the repository at this point in the history
  7. Revert "more debug"

    This reverts commit 748514a.
    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8ab111e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2f1bb7a View commit details
    Browse the repository at this point in the history
  9. debug library path

    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    af9dc60 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    65985da View commit details
    Browse the repository at this point in the history
  11. .pth imports get exec()'d, so do not import site

    importing site has side effects which were messing up sys.path
    
    I wasn't sure what else to import, so I imported sys. An import is required
    to trigger the exec().
    cognifloyd committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1c85b02 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. pass known_paths to addpackage

    avoid duplicate entries and hopefully avoid
    adding system paths before the st2 paths.
    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    44eedb8 View commit details
    Browse the repository at this point in the history
  2. Add a dummy path in PYTHONPATH

    Trying to see if the system paths are already present.
    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    4753f50 View commit details
    Browse the repository at this point in the history
  3. Fix python_runner integration test of lib shadowing

    If this works, we can probably drop the FIXME in the test.
    With a pants-built virtualenv, pip always preferred the st2-venv-provided lib,
    so we have to add a constraint to get it
    to also install it in the pack venv.
    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    4546f72 View commit details
    Browse the repository at this point in the history
  4. Drop incorrect comment

    The system lib paths are already in the sys.path before site gets imported.
    Then, all .pth files append after that.
    So, this is expected.
    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    3f9332a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f461b42 View commit details
    Browse the repository at this point in the history
  6. Revert various debug bits

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    b65739b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2a7ce81 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    55ce66f View commit details
    Browse the repository at this point in the history
  9. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    aa19bd1 View commit details
    Browse the repository at this point in the history
  10. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    882e162 View commit details
    Browse the repository at this point in the history
  11. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    f7ad04e View commit details
    Browse the repository at this point in the history
  12. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d7aeafd View commit details
    Browse the repository at this point in the history
  13. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    9d7fbf7 View commit details
    Browse the repository at this point in the history
  14. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c525919 View commit details
    Browse the repository at this point in the history
  15. debug st2-run-pack-tests

    cognifloyd committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    cf3c48f View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    eb55e8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc117ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    307ee74 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f09c2ed View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fd1eff2 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    50d61b9 View commit details
    Browse the repository at this point in the history
  2. refactor ci

    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8bd1f50 View commit details
    Browse the repository at this point in the history
  3. Try w/o the PyOpenSSL req hack

    GHA isn't failing with the RabbitMQ errors anymore.
    Hopefully the hack isn't actually needed.
    
    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                     Removed dependencies                     ==
    
      pyopenssl                      24.1.0
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f36285a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d35a99f View commit details
    Browse the repository at this point in the history
  5. Drop amqp constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      amqp                           5.0.6        -->   5.2.0
      vine                           5.0.0        -->   5.1.0
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9720e5c View commit details
    Browse the repository at this point in the history
  6. drop bcrypt constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      bcrypt                         3.2.2        -->   4.1.2
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    1bd30bc View commit details
    Browse the repository at this point in the history
  7. drop greenlet constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      greenlet                       1.1.3.post0   -->   3.0.3
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    39a3299 View commit details
    Browse the repository at this point in the history
  8. drop tenacity constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      tenacity                       6.3.1        -->   8.2.3
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2443c82 View commit details
    Browse the repository at this point in the history
  9. drop oslo.utils constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      oslo-utils                     4.13.0       -->   7.1.0
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    bd95f5c View commit details
    Browse the repository at this point in the history
  10. drop cffi constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      cffi                           1.14.6       -->   1.16.0
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3317c30 View commit details
    Browse the repository at this point in the history
  11. drop kombu constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      kombu                          5.0.2        -->   5.3.6
    
    ==                      Added dependencies                      ==
    
      typing-extensions              4.11.0
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f3c2401 View commit details
    Browse the repository at this point in the history
  12. drop stevedore constraint

    Lockfile diff: lockfiles/st2.lock [st2]
    
    ==                    Upgraded dependencies                     ==
    
      stevedore                      2.0.1        -->   5.2.0
    cognifloyd committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2e90551 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    025729f View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Configuration menu
    Copy the full SHA
    9fff939 View commit details
    Browse the repository at this point in the history
  2. Add pants+pex hermetic_scripts workaround to st2-run-pack-tests

    By default, pants+pex adds `-sE` to the virtualenv/bin scripts which prevents
    PYTHONPATH and other PYTHON* vars from affecting the program.
    
    st2-run-pack-tests uses PYTHONPATH, however, so bypass the script if it is hermetic.
    cognifloyd committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    95c8b57 View commit details
    Browse the repository at this point in the history
  3. drop hermetic_scripts workaround from Makefile

    to make sure this new method works for running nosetests.
    cognifloyd committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5a66bce View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    99410d4 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    51be306 View commit details
    Browse the repository at this point in the history