Renew certs in ssl_certs fixture #6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The distinguished_name section is not for CA, but for the other certs. Rename it to make the purpose clearer.
cognifloyd
added
tests
infrastructure: ci/cd
no changelog
pull-request-size
bot
added
the
size/L
guzzijones
approved these changes
Feb 16, 2024
|
I'm temporarily skipping the circlieci requirement so we can get this CI fix in. We can work on the CircleCI issue in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6137
I wrote a script to renew all of the certs in the fixture. I focused on figuring out how to each of the files could have been initially created so that I could reproduce the same method during renewal.
I used a renewal period of 15 years so we don't have to deal with this very often.