Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete action/workflow #898

Merged
merged 5 commits into from
Aug 18, 2021

Conversation

pradnya-orchestral
Copy link
Contributor

Added delete button in action component page , called delete API and made other required code changes for delete action/workflow functionality.

@m4dcoder m4dcoder added this to the 3.6.0 milestone Jul 1, 2021
Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradnya-orchestral

  • When I delete two actions in sequence, the previous action that I deleted will pop back up under the list at the pack. When I hit browser refresh button, then both actions are gone.
  • Can the confirmation popup look similar to the theme for the website? Can the message say "You are about to delete the action .<action.name>. This operation is irreversible. Are you sure?"
  • The delete operation is temporary here. The files are still on the system. If st2 is restarted/reloaded, the actions will get reregistered again. Please work with a backend developer to update the API to delete the action to also remove the files from the file system (or archive it somewhere else) so that it doesn't get re-register on st2ctl reload.

@m4dcoder
Copy link
Contributor

The delete operation is temporary here. The files are still on the system. If st2 is restarted/reloaded, the actions will get reregistered again. Please work with a backend developer to update the API to delete the action to also remove the files from the file system (or archive it somewhere else) so that it doesn't get re-register on st2ctl reload.

@pradnya-orchestral The backend changes are almost done at StackStorm/st2#5304 which will delete the action metadata and script files.

Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I click on an action, click on delete, and confirm, the UI will still keep me on the detail page for the deleted action. After delete confirmation and if the API call is successful, can we redirect the action details page (maybe to the default when I initially click on the Actions tab)?

@pradnya-orchestral
Copy link
Contributor Author

pradnya-orchestral commented Aug 18, 2021

What I have done previously was working fine but sometime Props data not get updated there are few reason like network issue or sometime Api call is taking lots of time to get updated data, that's why UI keep on deleted action detail page, so now after successful deletion I am navigating to action detail page which is like default when we click on action tab so now always first action will rendered on page after delete.

@m4dcoder m4dcoder merged commit 9c578e2 into StackStorm:master Aug 18, 2021
@pradnya-orchestral pradnya-orchestral deleted the Delete_Action/Workflow branch December 20, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants