Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording of success and fail messages #266

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

pofl
Copy link
Contributor

@pofl pofl commented Aug 22, 2023

Type of Change

  • Bugfix
  • Enhancement / new feature ?
  • Refactoring
  • Documentation ?

Description

Improve wording of default success and fail messages because what they say is just incorrect.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@0x46616c6b 0x46616c6b merged commit f2462c1 into main Aug 22, 2023
3 of 4 checks passed
@0x46616c6b 0x46616c6b deleted the improve-default-messages branch August 22, 2023 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants