Allow passing of different Dockerfile locations #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
flaxel
reviewed
Jan 25, 2023
| @@ -83,6 +83,8 @@ jobs: | |||
| docker-build-target: "any target" | |||
| # optional: name of the docker image, default: private/<repository_name> | |||
| docker-image: <your-image> | |||
| # optional: path to the Dockerfile, default: ./Dockerfile | |||
flaxel
approved these changes
Jan 25, 2023
| @@ -74,13 +74,15 @@ on: [ push ] | |||
|
|
|||
| jobs: | |||
| gitops: | |||
| uses: Staffbase/gha-workflows/.github/workflows/template_gitops.yml@v1.10.0 | |||
| uses: Staffbase/gha-workflows/.github/workflows/template_gitops.yml@v1.11.0 | |||
There was a problem hiding this comment.
Could we create the release after the PR from Kai is also merged? 🤔
There was a problem hiding this comment.
Sure, if doesn't take days... 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The GitOps Action actually supports passing a
docker-fileargument. However, this action doesn't support it. By adding it here, it allows us to use this action even if we have a Dockerfile that isn't in the current working directory.Checklist