Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Sign in with Apple #39

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 27, 2023

Enable Sign in with Apple

♻️ Current situation & Problem

All the necessary steps for Sign in with Apple are made. This PR configured Sign in with Apple to be displayed and pulls in some important fixes from the package dependencies.

⚙️ Release Notes

  • Introduce support for Sign in with Apple 🎉

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #39 (a44a678) into main (2acee33) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files          63       63           
  Lines        2306     2306           
=======================================
  Hits         1959     1959           
  Misses        347      347           
Files Coverage Δ
NAMS/NAMSAppDelegate.swift 97.06% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acee33...a44a678. Read the comment docs.

@Supereg Supereg marked this pull request as ready for review October 27, 2023 23:58
@Supereg Supereg merged commit 229647c into main Oct 28, 2023
7 checks passed
@Supereg Supereg deleted the feature/enable-sign-in-with-apple branch October 28, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant