Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI text updates + Removal of an onboarding view + updated consent #21

Merged
merged 2 commits into from
May 14, 2024

Conversation

aalami5
Copy link
Contributor

@aalami5 aalami5 commented May 14, 2024

Name of the PR

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Text UI edits in onboarding + removal of InterestingModuels view
@PSchmiedmayer PSchmiedmayer self-requested a review May 14, 2024 04:22
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aalami5; looks great!

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 22.33%. Comparing base (081d931) to head (5ae06f4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   21.92%   22.33%   +0.41%     
==========================================
  Files          48       47       -1     
  Lines        1469     1438      -31     
==========================================
- Hits          322      321       -1     
+ Misses       1147     1117      -30     
Files Coverage Δ
OwnYourData/Account/AccountSetupHeader.swift 0.00% <ø> (ø)
OwnYourData/Onboarding/OnboardingFlow.swift 96.56% <ø> (-0.11%) ⬇️
OwnYourData/Onboarding/Welcome.swift 94.60% <100.00%> (ø)
OwnYourData/Onboarding/HealthKitPermissions.swift 2.23% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081d931...5ae06f4. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 3165d7f into main May 14, 2024
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the UI_Improvements branch May 14, 2024 06:26
@aalami5 aalami5 restored the UI_Improvements branch May 15, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants