Use string catalogues and fix non-localized strings

[vishnuravi]

Use string catalogues and fix non-localized strings

⚙️ Release Notes

Migrates to use of string catalogues for localization and fixes a string that is not being drawn from the localization files.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[vishnuravi]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

[codecov]

Codecov Report

Merging #33 (8051627) into main (5bbeed7) will decrease coverage by 76.41%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #33       +/-   ##
==========================================
- Coverage   76.42%   0.00%   -76.41%     
==========================================
  Files         114     114               
  Lines        3952    3964       +12     
==========================================
- Hits         3020       0     -3020     
- Misses        932    3964     +3032     

Files	Coverage Δ
Sources/SpeziAccount/AccountSetup.swift	0.00% <0.00%> (-72.50%)	⬇️
...s/SpeziAccount/Mock/MockSimpleAccountService.swift	0.00% <0.00%> (ø)
...count/Views/AccountSetup/ExistingAccountView.swift	0.00% <0.00%> (-67.85%)	⬇️
...s/SpeziAccount/Views/UserIdPasswordResetView.swift	0.00% <0.00%> (-85.29%)	⬇️
.../SpeziAccount/AccountValue/Keys/AccountIdKey.swift	0.00% <0.00%> (-21.42%)	⬇️
...count/ViewModel/AccountOverviewFormViewModel.swift	0.00% <0.00%> (-93.45%)	⬇️
...SpeziAccount/Views/DataDisplay/SimpleTextRow.swift	0.00% <0.00%> (-72.22%)	⬇️
...iews/AccountOverview/AccountOverviewSections.swift	0.00% <0.00%> (-89.08%)	⬇️
Sources/SpeziAccount/AccountOverview.swift	0.00% <0.00%> (-56.36%)	⬇️
...ment/AccountServiceConfiguration+Environment.swift	0.00% <0.00%> (-100.00%)	⬇️
... and 1 more

... and 94 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bbeed7...8051627. Read the comment docs.

[Supereg]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection to the lines.

[Supereg]

Thank you 🚀

[vishnuravi]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection to the lines.

Thanks. I added this and then I got a line length - sometimes you just can't win!!

[Supereg]

@Supereg any idea why we are getting the discouraged_optional_collection error here? Those files were not touched and seemed to have passed before?

Not sure why they pop up now. But feel free to add some //swiftlint:disable:this discouraged_optional_collection to the lines.

Thanks. I added this and then I got a line length - sometimes you just can't win!!

There is also a swiftlint:disable:previous ... which might be helpful here 😅

[PSchmiedmayer]

@vishnuravi @Supereg Thank you for this fix!

Can we use this PR to directly resolve #22 which would have also been helpful to be done right in #32 to ensure that we don't run into the same issues again?
String catalogues should flag these issues and should automate these processes in the future 👍

[Supereg]

Thanks for the great work 🚀

As we migrated to String catalogues, we have some strings being picked up from the mock or preview implementations. I annotated every localization key I could find.
Would be great if you could review the usages of those keys and check if it makes sense to use the Text(verbatim:) initializer instead, or, otherwise, add a translation for those strings.

Otherwise, the PR looks great, thanks for the effort 🎉

[PSchmiedmayer]

Thank you @vishnuravi! Happy to get the PR merged once @Supereg is happy and his comments are resolved 🚀

[PSchmiedmayer]

Would be great if we can also just include the MD link check in there as well, just so we get it into the different repos as we make different smaller or bigger PRs 👍

[PSchmiedmayer]

@vishnuravi Following up on our discussion today: I addressed most of the issues with the localization files and only needed to translate a few very limited elements and added comments for the rest.

Looking forward to getting the PR finished and feel free to merge it once all the conversations are resolved 👍

[Supereg]

fyi, I'm currently rebasing this PR and taking care of it getting it merged if that is alright for you @vishnuravi 👍

[vishnuravi]

fyi, I'm currently rebasing this PR and taking care of it getting it merged if that is alright for you @vishnuravi 👍

That sounds great, thank you @Supereg!

[PSchmiedmayer]

Thank you for finishing the PR @Supereg and thanks for all the work here @vishnuravi!