Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow voice selection and personal voices #8

Merged
merged 15 commits into from
Jul 1, 2024
Merged

Conversation

vishnuravi
Copy link
Member

@vishnuravi vishnuravi commented May 11, 2024

Allow voice selection and personal voices

♻️ Current situation & Problem

Users can optionally specify a language for the voice to use when synthesizing speech, but cannot select a specific voice. As there are many voice options in iOS, including personal voices, this would be a great feature to support.

⚙️ Release Notes

  • Allows users to specify a voice when generating speech.
  • Provides an array of voices in the user's current locale.
  • Provides a function for requesting permission and accessing personal voices.

✅ Testing

  • Updates the test app with a selection of voices that can be chosen to synthesize speech.
  • Personal voices cannot be tested on a simulator.

📝 Documentation

  • Updates the README with an example of voice selection in a SwiftUI interface
  • Adds instructions for requesting access to Personal Voices.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@vishnuravi vishnuravi marked this pull request as ready for review June 30, 2024 22:46
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 26.71%. Comparing base (60b8cdb) to head (502eedd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   18.08%   26.71%   +8.63%     
==========================================
  Files           2        2              
  Lines         166      191      +25     
==========================================
+ Hits           30       51      +21     
- Misses        136      140       +4     
Files Coverage Δ
...ces/SpeziSpeechSynthesizer/SpeechSynthesizer.swift 35.45% <40.00%> (+22.49%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b8cdb...502eedd. Read the comment docs.

@vishnuravi vishnuravi changed the title Allow voice selection Allow voice selection and personal voices Jul 1, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; I have fixed the codecov upload and some documentation improvements. Happy to see this merged 👍

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jul 1, 2024
@vishnuravi vishnuravi merged commit 0b79f72 into main Jul 1, 2024
18 checks passed
@vishnuravi vishnuravi deleted the select-voices branch July 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants