-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates modules for Standard changes in Spezi 0.7.0 #8
Conversation
@PSchmiedmayer the swiftlint error here in Tests/UITests/TestApp/TestApp.swift appears to be a false positive? I have not edited this file. (See related issue: realm/SwiftLint#4843) |
If I may provide input on this. |
Hi @Supereg thank you, that makes sense. I fixed this for the time being by setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishnuravi Thank you for the PR, that is very helpful! @niallkehoe that might also help you in taking a look at the Scheduler Module and the HPDS and PRISM apps 👍
Thank you @Supereg on the input!
@vishnuravi I like the approach of using attributes_with_arguments_always_on_line_above
, that looks like a clean solution here.
The UI tests are passing locally, but are stuck on "Running..." on the UI test action. Will debug. |
@vishnuravi I took a closer look at our build agents and fixed a few things. It should build now and should be ready to merge the PR 👍 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
===========================================
+ Coverage 23.63% 91.87% +68.25%
===========================================
Files 5 5
Lines 381 381
===========================================
+ Hits 90 350 +260
+ Misses 291 31 -260
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thanks @PSchmiedmayer, glad the tests are passing now, will merge! |
Updates module for Standard changes in Spezi 0.7.0
♻️ Current situation & Problem
Spezi 0.7.0 changes how
Standard
s are defined and has made using aStandard
in a module optional. The SpeziStorage module previously required defining aStandard
even though it does not use one.💡 Proposed solution
Updates SpeziStorage to remove the
Standard
requirement, which makes it simpler to use.Testing
Tests have been updated.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: