Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates modules for Standard changes in Spezi 0.7.0 #8

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

vishnuravi
Copy link
Member

Updates module for Standard changes in Spezi 0.7.0

♻️ Current situation & Problem

Spezi 0.7.0 changes how Standards are defined and has made using a Standard in a module optional. The SpeziStorage module previously required defining a Standard even though it does not use one.

💡 Proposed solution

Updates SpeziStorage to remove the Standard requirement, which makes it simpler to use.

Testing

Tests have been updated.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@vishnuravi
Copy link
Member Author

vishnuravi commented Jul 27, 2023

@PSchmiedmayer the swiftlint error here in Tests/UITests/TestApp/TestApp.swift appears to be a false positive? I have not edited this file. (See related issue: realm/SwiftLint#4843)

@Supereg
Copy link
Member

Supereg commented Jul 27, 2023

@PSchmiedmayer the swiftlint error here in Tests/UITests/TestApp/TestApp.swift appears to be a false positive? I have not edited this file. (See related issue: realm/SwiftLint#4843)

If I may provide input on this.
You are seeing this issue due to an upgraded swiftlint version introduced with the new swiftlint GitHub action.
We kinda came to the conclusion to just remove the attributes rule from the swiftlint config for now. At least that was what we were doing in most of the other projects. Maybe it’s worth creating a GitHub issue over at the ’.github’ project as we could discuss reintroducing the rule with a more customized configuration?

@vishnuravi
Copy link
Member Author

@PSchmiedmayer the swiftlint error here in Tests/UITests/TestApp/TestApp.swift appears to be a false positive? I have not edited this file. (See related issue: realm/SwiftLint#4843)

If I may provide input on this. You are seeing this issue due to an upgraded swiftlint version introduced with the new swiftlint GitHub action. We kinda came to the conclusion to just remove the attributes rule from the swiftlint config for now. At least that was what we were doing in most of the other projects. Maybe it’s worth creating a GitHub issue over at the ’.github’ project as we could discuss reintroducing the rule with a more customized configuration?

Hi @Supereg thank you, that makes sense. I fixed this for the time being by setting attributes_with_arguments_always_on_line_above to false as described here: realm/SwiftLint#4855.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnuravi Thank you for the PR, that is very helpful! @niallkehoe that might also help you in taking a look at the Scheduler Module and the HPDS and PRISM apps 👍

Thank you @Supereg on the input!
@vishnuravi I like the approach of using attributes_with_arguments_always_on_line_above, that looks like a clean solution here.

@vishnuravi
Copy link
Member Author

The UI tests are passing locally, but are stuck on "Running..." on the UI test action. Will debug.

@PSchmiedmayer
Copy link
Member

@vishnuravi I took a closer look at our build agents and fixed a few things. It should build now and should be ready to merge the PR 👍

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8 (15780c0) into main (5dc128a) will increase coverage by 68.25%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #8       +/-   ##
===========================================
+ Coverage   23.63%   91.87%   +68.25%     
===========================================
  Files           5        5               
  Lines         381      381               
===========================================
+ Hits           90      350      +260     
+ Misses        291       31      -260     
Files Changed Coverage Δ
Sources/SpeziLocalStorage/LocalStorage.swift 89.43% <ø> (+21.16%) ⬆️
Sources/SpeziSecureStorage/SecureStorage.swift 94.89% <ø> (+94.32%) ⬆️
...ources/SpeziLocalStorage/LocalStorageSetting.swift 97.30% <100.00%> (+48.65%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc128a...15780c0. Read the comment docs.

@vishnuravi
Copy link
Member Author

@vishnuravi I took a closer look at our build agents and fixed a few things. It should build now and should be ready to merge the PR 👍

Thanks @PSchmiedmayer, glad the tests are passing now, will merge!

@vishnuravi vishnuravi enabled auto-merge (squash) July 28, 2023 02:10
@vishnuravi vishnuravi disabled auto-merge July 28, 2023 02:14
@vishnuravi vishnuravi merged commit 0658e43 into main Jul 28, 2023
8 checks passed
@vishnuravi vishnuravi deleted the update-spezi branch July 28, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants