Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Preconditions Message Use Patten #57

Closed
romeara opened this issue Sep 17, 2019 · 0 comments
Closed

Enhance Preconditions Message Use Patten #57

romeara opened this issue Sep 17, 2019 · 0 comments
Assignees
@romeara
Labels
enhancement New feature or request
Milestone
0.5.0

Comments

@romeara
Copy link
Member

romeara commented Sep 17, 2019

Currently, Preconditions will accept full messages or suppliers for messages - however, his often requires wrapping MoreStrings.format() in a supplier call. It may be preferable to either provide a call that natively returns a supplier, or adjust the way the strings utility and Preconditions use each other to allow Preconditions to support native message formatting ( checkXXX(boolean, String template, Object...) )
@romeara romeara added the enhancement New feature or request label Sep 17, 2019
@romeara romeara added this to the next-release (minor) milestone Sep 17, 2019
@romeara romeara self-assigned this Sep 24, 2019
romeara added a commit that referenced this issue Sep 25, 2019
@romeara
Merge pull request #58 from StarChart-Labs/task/romeara/57-preconditi…
23ce1bf 
…ons-formatted

Resolves GH-57 Adds Preconditions check* calls with String formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romeara romeara

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@romeara