[BugFix] Fix restore download failure for the file of GIN #44957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I'm doing: Currently, we hard core two kinds of GIN index file which is end with segments_2 and segments.gen. But the index file maybe contains some file which are end with segments_1, segments_2,...,segments_n etc. We will download these files fail because the incorrent file name check. What I'm doing: Check whether the file name contain segments instead of hard coding the suffix. Signed-off-by: srlch <linzichao@starrocks.com>
trueeyu
reviewed
Apr 29, 2024
trueeyu
reviewed
Apr 29, 2024
Signed-off-by: srlch <linzichao@starrocks.com>
wyb
reviewed
Apr 29, 2024
be/src/runtime/snapshot_loader.cpp
Outdated
Comment on lines
760
to
763
| if (str.find(match) != std::string::npos) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| if (str.find(match) != std::string::npos) { | |
| return true; | |
| } | |
| return false; | |
| return str.find(match) != std::string::npos; |
Signed-off-by: srlch <linzichao@starrocks.com>
trueeyu
approved these changes
Apr 29, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
wyb
approved these changes
Apr 29, 2024
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
Signed-off-by: srlch <linzichao@starrocks.com> (cherry picked from commit c2503b7)
42 tasks
srlch
added a commit
to srlch/starrocks
that referenced
this pull request
Apr 30, 2024
This pr is very similar with pr(StarRocks#44957). In StarRocks#44957, we fix the problem for download procedure. In this pr, we fix the problem for rename procedure for restore. Signed-off-by: srlch <linzichao@starrocks.com>
24 tasks
42 tasks
node
pushed a commit
to vivo/starrocks
that referenced
this pull request
May 9, 2024
…44957) Signed-off-by: srlch <linzichao@starrocks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Currently, we hard code two kinds of GIN index file which is end with segments_2 and segments.gen. But the index file maybe contains some file which are end with segments_1, segments_2,...,segments_n etc. We will download these files fail because the incorrent file name check.
What I'm doing:
Check whether the file name contain segments instead of hard coding the suffix
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: