Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix uncorrect new path for GIN file after restore #45016

Merged
merged 4 commits into from
Apr 30, 2024
Merged

[BugFix] Fix uncorrect new path for GIN file after restore #45016

merged 4 commits into from
Apr 30, 2024

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Apr 30, 2024 •
edited
Loading

Why I'm doing:

This pr is very similar with pr(#44957). In #44957, we fix the problem for download procedure. In this pr, we fix the problem for rename procedure for restore.

What I'm doing:

check segments instead of segments_2

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@srlch
[BugFix] Fix uncorrect new path for GIN file after restore
728f2c3 
This pr is very similar with pr(StarRocks#44957). In StarRocks#44957, we fix
the problem for download procedure. In this pr, we fix the
problem for rename procedure for restore.

Signed-off-by: srlch <linzichao@starrocks.com>
@srlch srlch requested a review from a team as a code owner April 30, 2024 04:50
@mergify mergify bot assigned srlch Apr 30, 2024
@github-actions github-actions bot added the 3.3 label Apr 30, 2024
@srlch srlch mentioned this pull request Apr 30, 2024
Closed
@srlch
refactor
e0e8997 
Signed-off-by: srlch <linzichao@starrocks.com>
@srlch srlch requested review from a team as code owners April 30, 2024 05:07
trueeyu
trueeyu previously approved these changes Apr 30, 2024
View reviewed changes
@srlch
fix
a192b24 
Signed-off-by: srlch <linzichao@starrocks.com>
@srlch
Fix compile
3601466 
Signed-off-by: srlch <linzichao@starrocks.com>
@wyb wyb enabled auto-merge (squash) April 30, 2024 06:24
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 8 / 8 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/snapshot_loader.cpp 1 1 100.00% []
🔵 be/src/storage/inverted/clucene/clucene_plugin.h 6 6 100.00% []
🔵 be/src/storage/snapshot_manager.cpp 1 1 100.00% []

@wyb wyb merged commit 7a08e63 into StarRocks:main Apr 30, 2024
46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 30, 2024
@srlch @mergify
[BugFix] Fix uncorrect new path for GIN file after restore (#45016)
ad2c77d 
Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit 7a08e63)
@mergify mergify bot mentioned this pull request Apr 30, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2024
@mergify @srlch
[BugFix] Fix uncorrect new path for GIN file after restore (backport #…
e37bee0 
…45016) (#45030)

Co-authored-by: srlch <111035020+srlch@users.noreply.github.com>
node pushed a commit to vivo/starrocks that referenced this pull request May 9, 2024
@srlch @node
[BugFix] Fix uncorrect new path for GIN file after restore (StarRocks…
95bff46 
…#45016)

Signed-off-by: srlch <linzichao@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@wyb wyb wyb approved these changes

Assignees

@srlch srlch

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srlch @wyb @trueeyu