Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix restore download failure for the file of GIN (backport #44957) #44972

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 29, 2024

Why I'm doing:

Currently, we hard code two kinds of GIN index file which is end with segments_2 and segments.gen. But the index file maybe contains some file which are end with segments_1, segments_2,...,segments_n etc. We will download these files fail because the incorrent file name check.

What I'm doing:

Check whether the file name contain segments instead of hard coding the suffix

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #44957 done by [Mergify](https://mergify.com). ## Why I'm doing: Currently, we hard code two kinds of GIN index file which is end with segments_2 and segments.gen. But the index file maybe contains some file which are end with segments_1, segments_2,...,segments_n etc. We will download these files fail because the incorrent file name check.

What I'm doing:

Check whether the file name contain segments instead of hard coding the suffix

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit c2503b7)
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 29, 2024 07:59
@andyziye andyziye disabled auto-merge April 29, 2024 08:20
@andyziye andyziye merged commit 49bfec4 into branch-3.3 Apr 29, 2024
32 of 33 checks passed
@andyziye andyziye deleted the mergify/bp/branch-3.3/pr-44957 branch April 29, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants