Feature image markdown #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheelercj
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the mouse is hovering over an image, the Stardown menu will add an additional option to create markdown syntax of the image using the source url from the page.
I've added an additional feature of having Stardown create a notification that the markdown was successfully created. Where in the case of the image, it provides the name of the image which is extrapolated from its filename.
Changes to
content.jswas necessary on the selection side to address the message object I was sending vs the string literal being used by selection, so the type that theonMessagemethod was receiving was a consistent data type.This PR will close issue#13