yamchan: a new channel class to read and write ASDF wcs objects #12
Conversation
src/yamlchan.c
Outdated
| * - Frames must be basic Frames or SkyFrames. | ||
| * - The following SkyFrame systems are not supported: GAPPT, | ||
| * HELIOECLIPTIC, J2000, UNKNOWN. | ||
| * - Only the following Napping classes are supported: |
There was a problem hiding this comment.
Napping? (and then it doesn't list anything)
There was a problem hiding this comment.
A nap is what I feel I need after 2 weeks frantic holiday! I've added the list of supported Mapping classes, which is: CmpMap, TranMap, UnitMap, ZoomMap, ShiftMap, WinMap, MatrixMap, PermMap, WcsMap, PolyMap, ChebyMap.
|
The naming was modelled on FitsChan. So YAML is the storage format and the specific data model is (or will be) indicated by an Encoding attribute. At the moment, there's currently no need for an Encoding attribute since only one encoding (ASDF) is supported. But my hope is that I could find time, some time, to add an AST Native encoding to YamlChan (like FitsChan has a Native encoding). And who knows what other schemes people will come up with for storing WCS in yaml format. |
|
I think I'd feel better if there was an encoding attribute now that said |
|
OK. I can do that. |
Currently, "ASDF" is the only legal value for YamlEncoding.
|
Done. So where do we go now with this? |
The AllowSimplify flag is a protected internal feature that is only relevant to a Mapping when it is being simplified. Once the simplification is complete, the flag should be cleared so that it does not appear within public dumps of the Mapping.
See https://asdf-standard.readthedocs.io