-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAVE - Améliorations de la personnalisation du mapping ROME/NAF #370
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae4ee7f
Prepopulate `update_jobs_form` and try to simplify its code
kemar de0bba4
New tests for ROMEs modifications
kemar f1ab5ca
Test the OfficeUpdateJobsForm class
kemar f445b08
Use a constant for SIRET_REGEX
kemar c386918
Use buttons instead of links
kemar f7ee4bb
Templating and wording
kemar 67712c7
Replace the `create_form` decorator by `office_identification_require…
kemar 7243aed
Don't use callables for `app_context` and `test_request_context` so a…
kemar c1c5b58
Use a proper POST-REDIRECT-GET for success pages
kemar 09b569f
Move and rewrite conact forms unit tests from /tests/app to /tests/web
kemar 508b6f7
Rename some office properties
kemar 3297a23
Use settings values for emails
kemar 60d35ae
Simplify get_recruiter_message()
kemar cb8c3af
Fix layout of success page
kemar 5cde69d
Fix unit tests
kemar 66c398d
Ensure that we have romes to boost
kemar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je suggère de garder seulement cette seconde méthode car la première me semble confusante, vu que partout ailleurs dans le code
rome
etrome_code
sont interchangeables et sont toujours la string de 5 caractères d'un code ROMEou alors renommer la première, car
romes
laisse croire que ce sont des codes ROME. peut-êtrenamed_romes
ouromes_with_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui, c'est tout à fait pertinent. Je vais renommer la première en
romes_for_naf_mapping
car ça décrit exactement ce que c'est : juste un shortcut vers leromes_for_naf
decommon.mapping
.