Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding check for nil values in SourceFields #16

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Adding check for nil values in SourceFields #16

merged 2 commits into from
Sep 12, 2019

Conversation

manossaratsis
Copy link

@manossaratsis manossaratsis commented Sep 12, 2019 •
edited
Loading

In the case where a feature includes a source field with a nil value, we are omitting the feature altogether and raising an error.

jerluc
jerluc requested changes Sep 12, 2019
View reviewed changes
es_source.go Outdated Show resolved Hide resolved
@jerluc jerluc mentioned this pull request Sep 12, 2019
Open
@manossaratsis manossaratsis merged commit 0da391a into master Sep 12, 2019
@manossaratsis manossaratsis deleted the nil-values branch September 12, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerluc jerluc jerluc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manossaratsis @jerluc