Feature/configure linter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Czino. |
|
Merge conflicts have been resolved. Small issues: unused imports, lax comparison, lines too long, biggest of which are sorting issues imposed by prettier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the
lintcommand threw an error so I added the dependencies to make it work.In this PR you'll also find that the
package-lock.jsonandyarn.lockcompletely changed. I deleted them and did a fresh install to get them to the latest version. Checked commit history and didn't find that versions of single modules have been updated (e.g. through Dependency Bot)Also I did not intentionally edit
lib/lib/interfaces.d.tsbut it got changed on install. Thedeclarehere does not seem relevant as it's already exported.