Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deck-components): add standalone slider component #96

Closed

Conversation

jessebofill
Copy link
Contributor

This is just the built in slider component. Note that this component does not give any indication of when it's focused, as that's normally indicated by the field.

@beebls
Copy link
Contributor

beebls commented Sep 30, 2023

Code all looks good, do you have a plugin that uses this so we can test?

@AAGaming00
Copy link
Member

AAGaming00 commented Sep 30, 2023

are you sure this isn't just a property of CommonUIModule?

@jessebofill
Copy link
Contributor Author

Code all looks good, do you have a plugin that uses this so we can test?

No, I don't. I just found it yesterday per AA's request.

are you sure this isn't just a property of CommonUIModule?

Ah indeed you are correct. I'll change that. Is there a reason why the other components are still found by toString'ing as opposed to just using the property name?

@AAGaming00
Copy link
Member

Ah indeed you are correct. I'll change that. Is there a reason why the other components are still found by toString'ing as opposed to just using the property name?

iirc that's only the ones that are outside commonui

also commonui didn't have names at all until like June, so some of the old code works that way, we should probably refactor that soon

@PartyWumpus PartyWumpus added the enhancement New feature or request label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants