Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plugin.uninstall callback support #555

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add Plugin.uninstall callback support #555

merged 2 commits into from
Mar 13, 2024

Conversation

wheaney
Copy link
Contributor

@wheaney wheaney commented Nov 1, 2023 •
edited
Loading

#536

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

Description

This fixes issue: #536

wheaney referenced this pull request in wheaney/decky-XRGaming Nov 1, 2023
@wheaney
Update to reduce duplicate install attempts when loading the plugin f…
f624f73 
…or a first-time install or version update, bump to version 0.2.6

Plugin._main no longer triggers an install, the UI will only trigger an checkInstallationStatus call once now
@TrainDoctor TrainDoctor mentioned this pull request Nov 1, 2023
Merged
5 tasks
@wheaney
Copy link
Contributor Author

wheaney commented Nov 2, 2023

Here is the PR for the plugin template update: SteamDeckHomebrew/decky-plugin-template#34

@TrainDoctor TrainDoctor added the enhancement New feature or request label Nov 2, 2023
@wheaney
Copy link
Contributor Author

wheaney commented Nov 7, 2023

@TrainDoctor what's next for this?

@TrainDoctor
Copy link
Member

@TrainDoctor what's next for this?

Needs testing. @SteamDeckHomebrew/decky-testers please give this a shot and let me know if you encounter any issues.

@TrainDoctor
Copy link
Member

@wheaney apologies for the delay. I finally have time to give this a whirl tomorrow. If you can rebase it to latest main that'd make it much easier for me to test.

@wheaney
Copy link
Contributor Author

wheaney commented Dec 16, 2023

I'm not sure what was going on with that first merge, but I think it's all sync'ed up now.

JohnnyCrazy
JohnnyCrazy previously requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@JohnnyCrazy JohnnyCrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition - can you remove the empty file and rebase? Will do some testing the next days.

contrib/deck.sh Outdated Show resolved Hide resolved
@TrainDoctor
Copy link
Member

I think this is a good addition - can you remove the empty file and rebase? Will do some testing the next days.

@wheaney once this change is made I can pretty easily merge this. Thanks.

@wheaney
Copy link
Contributor Author

wheaney commented Feb 26, 2024

The commit history here was confusing me, so I just rebased, removed the empty file, and force pushed.

@JohnnyCrazy
Copy link
Member

Mergin, thanks for this @wheaney !

@JohnnyCrazy JohnnyCrazy merged commit 34fb7bb into SteamDeckHomebrew:main Mar 13, 2024
6 checks passed
AAGaming00 pushed a commit that referenced this pull request Apr 24, 2024
@wheaney @AAGaming00
Add Plugin.uninstall callback support (#555)
a1a2961 
* Add Plugin.uninstall callback support

#536

* Remove empty deck.sh
bricefriha pushed a commit to bricefriha/decky-loader that referenced this pull request Jun 3, 2024
@wheaney @bricefriha
Add Plugin.uninstall callback support (SteamDeckHomebrew#555)
8de5218 
* Add Plugin.uninstall callback support

SteamDeckHomebrew#536

* Remove empty deck.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyCrazy JohnnyCrazy JohnnyCrazy left review comments

@marios8543 marios8543 Awaiting requested review from marios8543

@TrainDoctor TrainDoctor Awaiting requested review from TrainDoctor

Assignees

@wheaney wheaney

Labels
enhancement New feature or request
Projects
SDH Tracker
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wheaney @TrainDoctor @JohnnyCrazy