Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs websockets] plugin install progress #614

Merged
merged 6 commits into from
May 13, 2024

Conversation

PartyWumpus
Copy link
Member

@PartyWumpus PartyWumpus commented Apr 9, 2024

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: #595

Adds progress bars to the plugin install modal, and to the mass updater modal. Relies heavily on stuff in websockets though so won't be showing up in mainline decky until that's done.

singledownload.mp4
multidownload2.mp4

@PartyWumpus PartyWumpus marked this pull request as draft April 9, 2024 21:21
@AAGaming00
Copy link
Member

might look nicer either in the top right of the popup or inside the install button IMO

or perhaps as a bar going across the top of the modal

@AAGaming00
Copy link
Member

also don't use the fa spinner, use the one in DFL

@PartyWumpus
Copy link
Member Author

PartyWumpus commented May 13, 2024

also don't use the fa spinner, use the one in DFL

I switched to a downloading icon, which makes more sense I think anyways. The point of a spinner (or as the cool kids say: an annular throbber) is to show progress is happening when there's no progress bar, but... there's a progress bar.

might look nicer either in the top right of the popup or inside the install button IMO

or perhaps as a bar going across the top of the modal

Tried a couple other positions and honestly it looks best here. Might look better stretching the whole way across the modal but not sure. Going to merge as-is and it can be improved later by someone who knows what a good ui looks like.

Also I fixed the bug you see in the clip where the progress bar doesn't reset properly at the start of a new download.

@PartyWumpus PartyWumpus marked this pull request as ready for review May 13, 2024 13:42
@PartyWumpus PartyWumpus merged commit 372771a into aa/websockets May 13, 2024
7 of 9 checks passed
@PartyWumpus PartyWumpus deleted the websockets/plugin_install_progress branch May 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants