Persistent server list #293
Conversation
…th persistence. Exposed SteamClient.Servers.ServerListProvider (Defaults to NullServerListProvider)
…erverList. Updated sample #7.
| } | ||
| } | ||
| SteamClient.Servers.CellID = cellid; | ||
| SteamClient.Servers.ServerListProvider = new FileStorageServerListProvider("servers.bin"); |
There was a problem hiding this comment.
Suggest using a different name here - for anyone who has run Sample7 before, the existing data will be incompatible.
| byte[] buf = new byte[2048]; | ||
|
|
||
| timeOut = DateTime.Now.AddSeconds(TIMEOUT_DELAY); | ||
| nextResend = DateTime.Now.AddSeconds(RESEND_DELAY); | ||
| if (param is IPEndPoint) |
There was a problem hiding this comment.
This block seems iffy. You're doing is then as (better to just do as and check for null), followed by as and dereference. If param is neither an IPEndPoint not a Task<IPEndPoint>, this will just be a NullReferenceException. Better to just do an as for IPEndPoint, then a cast for Task<IPEndPoint>. Or ditch IPEndPoint entirely and always supply a task.
There was a problem hiding this comment.
I believe this is a mistake, as I don't think param can even be an IPEndPoint so this can be simplified to a single as
There was a problem hiding this comment.
If it's only ever Task<IPEndPoint> then just cast it.
…tion handling around tasks now looks explicitly at AggregateException. Cleaned up unnecessary MemoryStream copy in FIleStorageServerListProvider and IsolatedStorageServerListProvider.
|
👍 🚢 |
|
I can smell new release 😄 |
See sample 7 for how persistence can be used.