Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunar eclipse affects the unlit side of the Moon #3054

Open
Atque opened this issue Feb 9, 2023 · 4 comments
Open

Lunar eclipse affects the unlit side of the Moon #3054

Atque opened this issue Feb 9, 2023 · 4 comments
Assignees
Labels
feature Entirely new feature

Comments

@Atque
Copy link
Contributor

Atque commented Feb 9, 2023

This is a rarely seen limitation, but I thought I might report it anyway.

Lunar eclipses affect the non-illuminated side of the Moon. This is unrealistic, as the sunrays cannot reach those parts of the Moon during a lunar eclipse, and thus they should remain in total darkness. This is only visible from space, which is why this is a rarely seen limiation. See the screenshot below.
stellarium-167

A similar limiation is that the Earthshine is visible evenly across the non-illuminated lunar surface, even the parts from which the Earth is invisible. See the screenshot below. This is also only visible from space.
stellarium-169

@gzotti
Copy link
Member

gzotti commented Feb 10, 2023

Funny perspectives. Yes, the unilluminated side of the Moon which also points away from Earth should be black when seen from some "observer". From Earth you never see this issue.

The earthshine is modelled as "ambient" light component in the classical OpenGL model, so this is not directional. It is a limitation I have learned to live with.

@10110111
Copy link
Contributor

It is a limitation I have learned to live with.

Isn't it an artificial limitation? We can just add another uniform to show direction to the Earth and use the BRDF twice instead of once.

@alex-w alex-w added the bug Something likely wrong in the code label Feb 11, 2023
@gzotti
Copy link
Member

gzotti commented Feb 11, 2023

@10110111 if you can do that, please go ahead. For me the focus of this program is still earth-bound simulation.

@gzotti gzotti added feature Entirely new feature and removed bug Something likely wrong in the code labels Feb 11, 2023
@github-actions
Copy link

Hello @Atque!

Thank you for suggesting this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Entirely new feature
Development

No branches or pull requests

4 participants